Fix async validation in catalog form #5440
Conversation
* unresolved promises prevented ending of validation, so all promises all resolved
| .then((json) => { | ||
| if (json.resources.length > 0) { | ||
| if (json.resources.length > 0 && json.resources[0].id !== id) { |
There was a problem hiding this comment.
What if the result is not first in the array? I think we should use Array.prototype.find for this.
There was a problem hiding this comment.
There should not be more than one result, even if a user injects * to the name of the catalog.
There was a problem hiding this comment.
With find that code is almost unbreakable with [0] a lot of things can go wrong in future.
There was a problem hiding this comment.
I tested the * option on API and when you not put the query inside 's it would not use * as a regular expression.
However, if there is more than one result, it means there are two catalogs with the same name and the DB is already broken. 🗡️
But when I am thinking about it, a user could put the whole name into 's but that seems as a hacky way to name a catalog. Should I take care about these cases? 😸
There was a problem hiding this comment.
I would definitely use find. Rest does not bother me much.
There was a problem hiding this comment.
Ok! I will also investigate how to properly escape special characters... e.g. % in the name breaks it! 😢
There was a problem hiding this comment.
I think there should be some JS escaping tools. Using symbols like % is used for filtering etc in the MIQ API
There was a problem hiding this comment.
I changed it to
- it tries to find a catalog with the same name and different ID (no looking on the length of results)
- escaping only
%to%25
* name async validation checks if the name already exists but it did not check if the name exists on the same catalog -> now it checks id of the catalog with the same name and compares to its id
|
Checked commits rvsia/manageiq-ui-classic@c113510~...18cf9a7 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Services > Catalogs > Catalogs > Configuration > New/EditDescription
@miq-bot add_label hammer/no, services, react
@miq-bot add_reviewer @Hyperkid123