Add support for PF4 styling through webpack #5537
Conversation
| @@ -22,6 +22,8 @@ import { history } from '../miq-component/react-history.ts'; | |||
| import createReduxRoutingActions from '../miq-redux/redux-router-actions'; | |||
| import { formButtonsActionTypes, createFormButtonsActions } from '../forms/form-buttons-reducer'; | |||
|
|
|||
| import '../../assets/stylesheets/application-webpack.scss'; | |||
There was a problem hiding this comment.
Should we start separating the CSS too?
(Importing app/assets/stylesheets/ from webpack is surprising, let's not do that for any JS, but with css...
¯\_(ツ)_/¯ up to you :))
There was a problem hiding this comment.
Ideally we would not need any custom CSS 
but I get your point. Maybe /app/stylesheets?
There was a problem hiding this comment.
Works for me :) Thanks :)
(if you want to be 100% consistent, app/stylesheet, because asset pipeline has plurals but webpack has app/javascript. But both are fine :).)
(Or app/css because who remembers "stylesheet" :D But then somebody would add app/scss too :))
There was a problem hiding this comment.
/app/stylesheet it is then
|
I'll paste in issues as I find them Bef After Bef After |
|
Checked commit skateman@a1e4692 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Great, we still have no public announcement about PF4 being available in ivanchuk (and IE11 not), |
|
|
||
| @import '~@fortawesome/fontawesome-free/css/all.css'; | ||
| @import '~@fortawesome/fontawesome-free/scss/v4-shims.scss'; | ||
| @import '~@patternfly/patternfly-next/patternfly.scss'; |
There was a problem hiding this comment.
should be @patternfly/patternfly/patternfly.scss - #5635
There was a problem hiding this comment.
Yes, it wasn't when I read the docs about it ...
There was a problem hiding this comment.
Not blaming you, I still can't even find any docs about it :)
But looks like the last release of patternfly-next was in January, since then, it's the other one.
To avoid collisions with the old world, the new version is loaded through webpack instead of the asset pipeline. Reopen of #4841 as I accidentally deleted the branch.
@miq-bot add_label hammer/no, changelog/yes, graphics
@miq-bot add_reviewer @epwinchell
@miq-bot add_reviewer @himdel