Added Dialog name info on the Catalog Item summary screen #5599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thsi info was already being set, only needed to be displayed in view. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1461487
|
Checked commit h-kataria@1ab0aef with ruby 2.3.3, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
himdel
reviewed
May 17, 2019
| = _('Dialog') | ||
| .col-md-8 | ||
| %p.form-control-static | ||
| = @sb[:dialog_label] |
There was a problem hiding this comment.
Should this be = h(@sb[:dialog_label]) as in sand_tree_show and ab_show?
There was a problem hiding this comment.
..never mind :)
Looks like that's just an erb artifact..
- foo = 'ba<b>gr</b>ooo<br />'
Foo
= foo
Bar
= h(foo)the output for both is exactly the same
|
The spec failure doesn't seem related, restarting.. |
|
Indeed, the spec failure is on master as well :\ Looking :) EDIT: caused by ManageIQ/manageiq#18778 |
|
LGTM, fixes the bug, test failures unrelated :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This info was already being set, only needed to be displayed in view.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1461487
before
after
