Drop the timeline listnav decision logic for dashboard/timelines #5639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit skateman@f5d1d7c with ruby 2.3.3, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
h-kataria
reviewed
May 28, 2019
| @@ -73,7 +73,7 @@ def render_listnav_filename | |||
| elsif @explorer | |||
| "explorer" | |||
| elsif @layout == "timeline" | |||
There was a problem hiding this comment.
@skateman will @layout ever be timeline, this elsif probably should go away too
There was a problem hiding this comment.
@h-kataria yes, we need it for non-explorer screens that have Monitoring -> Timelines capability. For example infra/hosts...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer have timelines under cloud intel, so this is not necessary...
@miq-bot add_reviewer @epwinchell
@miq-bot add_reviewer @h-kataria
@miq-bot add_reviewer @romanblanco