TreeBuilders - replace @root_class = 'Klass' in constructor with a filter_root_class method #5662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lter_root_class method makes the inheritance approach a bit clearer, removes the need for super(*args) constructor in every class
himdel
changed the title
|
(and the answer is "no point" :)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the inheritance approach a bit clearer (I hope),
and removes the need for
super(*args)constructor in every class.Also added the method to
TreeBuilderConfiguredSystemswhich is an abstract class using the value from descendants.And removed two stray
attr_reader :tree_nodes, now also in TreeBuilder itself.And added
privatein places where it was obvious.Cc @skateman WDYT? (context: #5658 (comment))