Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expression Editor fix #5710

Merged
merged 1 commit into from Jun 14, 2019
Merged

Expression Editor fix #5710

merged 1 commit into from Jun 14, 2019

Conversation

epwinchell
Copy link
Contributor

This PR fixes a bug where the 'NOT' element could not be deleted in the Expression Editor.

https://bugzilla.redhat.com/show_bug.cgi?id=1720216

Old
Screen Shot 2019-06-14 at 11 55 12 AM

New
Screen Shot 2019-06-14 at 11 52 57 AM

@epwinchell
Copy link
Contributor Author

@miq-bot add_label bug, hammer/yes

@miq-bot
Copy link
Member

miq-bot commented Jun 14, 2019

Checked commit https://github.com/epwinchell/manageiq-ui-classic/commit/6843c15f0c0fb37c5bfb1ff8d0a7ae55a7bf4bc1 with ruby 2.3.3, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

app/controllers/application_controller/filter.rb

@h-kataria h-kataria self-assigned this Jun 14, 2019
@h-kataria h-kataria added this to the Sprint 114 Ending Jun 24, 2019 milestone Jun 14, 2019
@h-kataria h-kataria merged commit c008ca7 into ManageIQ:master Jun 14, 2019
simaishi pushed a commit that referenced this pull request Oct 21, 2019
@h-kataria @simaishi
Merge pull request #5710 from epwinchell/1720216
ecbec8c 
 Expression Editor fix

(cherry picked from commit c008ca7)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1763861
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit ecbec8cbaaae428e1d4e3e2f9e09ca88e3a59dd3
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Fri Jun 14 13:55:06 2019 -0400

    Merge pull request #5710 from epwinchell/1720216
    
     Expression Editor fix
    
    (cherry picked from commit c008ca7396f37e1af71ec9ff6815b67c804c201d)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1763861

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@h-kataria h-kataria

Labels
bug changelog/yes expressions/filters hammer/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@epwinchell @miq-bot @simaishi @h-kataria