Fix displaying 'Add a Provider' page on a fresh appliance #5783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug |
|
I don't see a problem with this approach 👍 (maybe a long term solution would be to change |
hstastna
force-pushed
the
Dashboard_display_no_record_add_provider
branch
2 times, most recently
from
2b9a53d
to
1dfcfbb
Compare
hstastna
changed the title
hstastna
force-pushed
the
Dashboard_display_no_record_add_provider
branch
from
fad7ea5
to
00021d8
Compare
|
Checked commits hstastna/manageiq-ui-classic@e6455be~...00021d8 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot add_label blocker |
h-kataria
approved these changes
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes BZ:
https://bugzilla.redhat.com/show_bug.cgi?id=1726721
The core of the problem is that, newly, new provider was added (Embedded Ansible) and it is preinstalled on MIQ by default, so after user (super admin) logs in, it behaves according to the code => Default dashboard is displayed, instead of expected 'Add a Provider' page, as it was in the past. So the code needs to be updated according to the new circumstance. However, there are more options to solve the situation. I decided to fix this in the same place where the problem takes shape. Feel free to add comments, ideas.
Before:
After:
Note:
I was able to reproduce the BZ locally. I've tested the fix with empty and non-empty DB, and it works.