Do not build the regex for embedded method when there's no fqname #5866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit skateman@24b46d5 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Jul 25, 2019
Do not build the regex for embedded method when there's no fqname (cherry picked from commit 33b898d) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1718495
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding an inline method to an automate method, we're building a regular expression that prevents the inline method tree select to add the inline the same method as the current method being edited. However, this fails when a new automate method is being created as it has no fqname and we can't build the regular expression.
This causes not to render the list of selected methods in the editor. The fix is to not build the regex when the fqname is not available.
@miq-bot assign @martinpovolny
@miq-bot add_label bug, hammer/yes, ivanchuk/yes, automation/automate
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1718495