Do not append title to breadcrumbs on show_list pages #5904
Conversation
rvsia
force-pushed
the
menu-hiearchy
branch
2 times, most recently
from
afc2f69
to
b856a23
Compare
rvsia
changed the title
|
@himdel Can you please check if everything is OK in optimization controller? 🙏 Thanks! |
| @@ -24,19 +24,12 @@ def breadcrumbs_options | |||
| { | |||
| :breadcrumbs => [ | |||
| {:title => _('Overview')}, | |||
| bc_optimization, | |||
| {:title => _("Optimization"), :url => url_for_only_path(:action => 'show_list', :id => nil)}, | |||
There was a problem hiding this comment.
You wil need to undo this change, #6041 changes how optimization does breadcrumbs, this PR won't affect it anymore
There was a problem hiding this comment.
It depends what will be merged sooner... 😏
I will undo it!
There was a problem hiding this comment.
Thanks, and if you can rebase, I'll try to test this one tomorrow :)
There was a problem hiding this comment.
Yeah, I’ll do it tomorrow.
|
Optimization is fine :) (but that's one of the few places where every screen has a breadcrumbs test :)) |
rvsia
force-pushed
the
menu-hiearchy
branch
2 times, most recently
from
7ec3224
to
29fec71
Compare
|
@himdel So I removed all changes to optimization controller 🗡️ |
|
(test failures will go away after #6041) |
|
LGTM, will merge green 👍 The only issue I am seeing is in the usual place - (and there is a tree even though it's a show_list, so, it kinda makes sense, for now, until we can make it into a proper explorer or something consistent with the other places) |
|
Checked commits rvsia/manageiq-ui-classic@28fe48a~...efd96c8 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
closes #5361
Description
When a header on the show_list page and a title in the menu are not the same, only the menu title is used.
Before
After
@miq-bot add_label changelog/yes, ivanchuk/no, breadcrumbs