Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report results: fix toolbar button display when in "filter". #5930

Merged
merged 1 commit into from Aug 5, 2019
Merged

Report results: fix toolbar button display when in "filter". #5930

merged 1 commit into from Aug 5, 2019

Conversation

martinpovolny
Copy link

Fixes: #5916

ping @lpichler

@miq-bot
Copy link
Member

miq-bot commented Aug 2, 2019

Checked commit martinpovolny@8acb916 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

lpichler
lpichler approved these changes Aug 2, 2019
View reviewed changes
Copy link
Contributor

@lpichler lpichler left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 tested thanks!

@mzazrivec mzazrivec self-assigned this Aug 5, 2019
@mzazrivec mzazrivec added this to the Sprint 117 Ending Aug 5, 2019 milestone Aug 5, 2019
@mzazrivec mzazrivec merged commit 53ae47a into ManageIQ:master Aug 5, 2019
simaishi pushed a commit that referenced this pull request Aug 5, 2019
@mzazrivec @simaishi
Merge pull request #5930 from martinpovolny/report_result_view_type_fix
c22dc9d 
Report results: fix toolbar button display when in "filter".

(cherry picked from commit 53ae47a)
@simaishi
Copy link
Contributor

simaishi commented Aug 5, 2019

Ivanchuk backport details:

$ git log -1
commit c22dc9d6bfd0c65f1ef4c39d666c847e13cf0c43
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Mon Aug 5 10:24:00 2019 +0200

    Merge pull request #5930 from martinpovolny/report_result_view_type_fix
    
    Report results: fix toolbar button display when in "filter".
    
    (cherry picked from commit 53ae47a11a85bd7268156e3a552030f39fd91279)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpichler lpichler lpichler approved these changes

Assignees

@mzazrivec mzazrivec

Labels
bug ivanchuk/backported overview/reporting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Report view: Dataview offers hybrid and chart in it is not supported
5 participants
@martinpovolny @miq-bot @simaishi @lpichler @mzazrivec