Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The dialog ems_network endpoint is wrong #5948

Merged
merged 1 commit into from Aug 8, 2019
Merged

The dialog ems_network endpoint is wrong #5948

merged 1 commit into from Aug 8, 2019

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Aug 6, 2019 •
edited by simaishi

The ems_network endpoint is singular (added in #5855).

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1732436

@miq-bot add_label bug, ivanchuk/yes
@martinpovolny sorry, my mistake

@miq-bot
Copy link
Member

miq-bot commented Aug 6, 2019

Checked commit d-m-u@a6d623e with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

@d-m-u d-m-u changed the title The endpoint isn't plural The dialog ems_network endpoint is wrong Aug 6, 2019
@mzazrivec mzazrivec self-assigned this Aug 7, 2019
@mzazrivec mzazrivec added this to the Sprint 118 Ending Aug 19, 2019 milestone Aug 8, 2019
@mzazrivec mzazrivec merged commit 4f7ee67 into ManageIQ:master Aug 8, 2019
simaishi pushed a commit that referenced this pull request Aug 8, 2019
@mzazrivec @simaishi
Merge pull request #5948 from d-m-u/fixing_ems_network_endpoint
3a7229a 
The dialog ems_network endpoint is wrong

(cherry picked from commit 4f7ee67)

https://bugzilla.redhat.com/show_bug.cgi?id=1732436
@simaishi
Copy link
Contributor

simaishi commented Aug 8, 2019

Ivanchuk backport details:

$ git log -1
commit 3a7229a590e25c3b55fedde373afe7320c727e51
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Thu Aug 8 11:30:07 2019 +0200

    Merge pull request #5948 from d-m-u/fixing_ems_network_endpoint
    
    The dialog ems_network endpoint is wrong
    
    (cherry picked from commit 4f7ee6769050cf1bc53be218be1d751302beecb3)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1732436

simaishi pushed a commit that referenced this pull request Aug 16, 2019
@mzazrivec @simaishi
Merge pull request #5948 from d-m-u/fixing_ems_network_endpoint
16ceadc 
The dialog ems_network endpoint is wrong

(cherry picked from commit 4f7ee67)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1741945
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit 16ceadca872665e0ff3b4bc6f9231790df50aa7a
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Thu Aug 8 11:30:07 2019 +0200

    Merge pull request #5948 from d-m-u/fixing_ems_network_endpoint
    
    The dialog ems_network endpoint is wrong
    
    (cherry picked from commit 4f7ee6769050cf1bc53be218be1d751302beecb3)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1741945

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzazrivec mzazrivec

Labels
bug hammer/backported ivanchuk/backported services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@d-m-u @miq-bot @simaishi @mzazrivec