Fixed call that build list of Storages to build Host file drop down #5952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-kataria
force-pushed
the
fix_host_files_drop_down_on_reconfigure_vms
branch
2 times, most recently
from
d7d9aae
to
6616c36
Compare
Issue was introduced in ManageIQ#3956, in commit 6df12d1 code that builds Host file drop down was changed `vm.try(:available_iso_names)` was removed and new method `get_iso_options` was added to build the list. Changed to get all storages that the vm's host is attached to instead of all of the vm's storages Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1689369
h-kataria
force-pushed
the
fix_host_files_drop_down_on_reconfigure_vms
branch
from
6616c36
to
5747aff
Compare
|
Checked commit h-kataria@5747aff with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Aug 7, 2019
…econfigure_vms Fixed call that build list of Storages to build Host file drop down (cherry picked from commit 24d94fb) https://bugzilla.redhat.com/show_bug.cgi?id=1689369
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue was introduced in #3956, in commit 6df12d1 code that builds Host file drop down was changed
vm.try(:available_iso_names)was removed and new methodget_iso_optionswas added to build the list. Changed to get all storages that the vm's host is attached to instead of all of the vm's storagesFixes https://bugzilla.redhat.com/show_bug.cgi?id=1689369
before
after
cc @agrare