Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed all drop downs in form to sort by name in ascending order. #597

Merged

Conversation

h-kataria
Copy link
Contributor

@h-kataria h-kataria commented Mar 6, 2017

@gmcculloug please review/test

before:
sort1_before
sort2_before

after:
sort1_after
sort2_after

@miq-bot
Copy link
Member

miq-bot commented Mar 6, 2017

This pull request is not mergeable. Please rebase and repush.

@h-kataria h-kataria force-pushed the sort_values_drop_downs_by_name branch from 3f085cc to b89573d Compare March 6, 2017 19:06
@miq-bot
Copy link
Member

miq-bot commented Mar 6, 2017

Checked commit h-kataria@b89573d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks good. 🍪

@gmcculloug
Copy link
Member

Tested PR and it looks good to me.

Note: You will not see duplicate Repository names now that PR #565 was merged early today.

@dclarizio Please review

@dclarizio dclarizio self-assigned this Mar 6, 2017
@dclarizio dclarizio merged commit f481725 into ManageIQ:master Mar 6, 2017
@dclarizio dclarizio added this to the Sprint 56 Ending Mar 13, 2017 milestone Mar 6, 2017
@h-kataria h-kataria deleted the sort_values_drop_downs_by_name branch March 8, 2017 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants