Build the selected node key from the session stored model in RBS 馃尦馃悶 #5974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before: After: LGTM 馃憤 but copypasting steps to reproduce or before/after pics would be great :P |
ZitaNemeckova
approved these changes
Aug 9, 2019
skateman
force-pushed
the
server-tree-prefix
branch
from
1de4559
to
7fa99bd
Compare
|
Checked commit skateman@7fa99bd with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
h-kataria
approved these changes
Aug 9, 2019
simaishi
pushed a commit
that referenced
this pull request
Aug 9, 2019
Build the selected node key from the session stored model in RBS 馃尦馃悶 (cherry picked from commit 55ab533) https://bugzilla.redhat.com/show_bug.cgi?id=1734393
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The node highlighting in the
TreeBuilderRolesByServerwent a little off after some refactoring because the model has not been calculated into the selected node's prefix generation. Therefore, only servers could be highlighted after a tree reload. If there was no server with the same ID as the role, no node has been selected after suspending/resuming a server role.This code is 馃崫 bad 馃崫 and I am working on a followup refactoring PR, but it touches too many pieces of session, so it takes me some time to make right all the wrongs. For more info about the reproducing, please see the BZ.
@miq-bot add_reviewer @ZitaNemeckova
@miq-bot assign @h-kataria
@miq-bot add_label bug, hammer/no, ivanchuk/yes, trees
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1734393