Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Tenant column from list view. #5996

Merged
merged 1 commit into from Aug 13, 2019

Conversation

h-kataria
Copy link
Contributor

Due to enhancement made in #5445 , Now list of tenant can be lot of tenant names and may not fit properly on the list view, so removing the column from list view as this information is available in a nice tree view on the details view of a Catalog Item.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1740172

before
before

after
after

Due to enhancement made in ManageIQ#5445 , Now list of tenant can be lot of tenant names and may not fit properly on the list view, so removing the column from list view as this information is available in a nice tree view on the details view of a Catalog Item.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1740172
@miq-bot
Copy link
Member

miq-bot commented Aug 12, 2019

Checked commit h-kataria@fa0b5cd with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@mzazrivec mzazrivec self-assigned this Aug 13, 2019
@mzazrivec mzazrivec added this to the Sprint 118 Ending Aug 19, 2019 milestone Aug 13, 2019
@mzazrivec mzazrivec merged commit 299c2c8 into ManageIQ:master Aug 13, 2019
simaishi pushed a commit that referenced this pull request Aug 16, 2019
@simaishi
Copy link
Contributor

Ivanchuk backport details:

$ git log -1
commit e5b48f9d86440f59f1093ae6d2e9d86e0224c3f7
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Tue Aug 13 11:13:19 2019 +0200

    Merge pull request #5996 from h-kataria/remove_tenant_column
    
    Removed `Tenant` column from list view.
    
    (cherry picked from commit 299c2c8cd6cd1c035283cf042ae9e1f16201563a)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1740172

@h-kataria h-kataria deleted the remove_tenant_column branch August 22, 2019 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants