Call miqCheckForChanges in breadcrumbs #6003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvsia
changed the title
rvsia
force-pushed
the
check-changes-breadcrumbs
branch
from
b38be36
to
2ece43d
Compare
rvsia
changed the title
|
Checked commit rvsia@2ece43d with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
Hyperkid123
approved these changes
Aug 14, 2019
|
@rvsia @h-kataria the BZ is targeted for 5.11.0 but this PR is |
|
@simaishi My bad. I didnt notice it. You can backport this. |
simaishi
pushed a commit
that referenced
this pull request
Aug 19, 2019
Call miqCheckForChanges in breadcrumbs (cherry picked from commit 1b4f058) https://bugzilla.redhat.com/show_bug.cgi?id=1725927
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1725927
Description
Steps to test:
Before
After
@miq-bot add_label bug, breadcrumbs, changelog/yes, ivanchuk/no
@miq-bot add_reviewer @Hyperkid123