Allow cloud volume to provide list of supported VMs for attachment #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the introduction of Amazon EBS block storage manager, the UI should no longer on cloud tenant of a cloud volume to provide the list of VMs that the volume can be attached to. EBS has no notion of tenants. It does, however, require that the volume resides in the same availability zone as the instance to which volume is being attached. This patch therefore asks the cloud volume to provide the list of instances that it can be attached to.
|
Checked commit gberginc@11e5c4c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Removed |
|
@mzazrivec I reset the milestone as we don't set that until merge and we are awaiting a review from @blomquisg |
|
@blomquisg @dclarizio OpenStack and Amazon providers have been updated with this method, so we should be able to merge this as well. |
blomquisg
approved these changes
Mar 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of Amazon EBS block storage manager, the UI should
no longer on cloud tenant of a cloud volume to provide the list of VMs
that the volume can be attached to. EBS has no notion of tenants. It
does, however, require that the volume resides in the same availability
zone as the instance to which volume is being attached.
This patch therefore asks the cloud volume to provide the list of
instances that it can be attached to.
Depends on: ManageIQ/manageiq#14058
@miq-bot add_label storage,pending core