Textual Summaries - textual_*_icon - support for fonticons, decorators #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead of the path directly to add support for fonticons too
also don' expect `:image`, it can be `:icon` instead
|
Checked commits https://github.com/himdel/manageiq-ui-classic/compare/74547e8480175ec95f4799059fc8b828f980bb03~...fd8628aa5f046be3eaf9979d1bbde4ec41c12561 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, textual summaries do use the
icon_or_imagepartial, so they do support fonticons and images .. but so far, don't use fonticons.This changes
textual_object_iconandtextual_class_iconto first try the decorator, and to be able to return a fonticon instead of image.@epwinchell This shouldn't break anything, except possibly show fonticons instead of
vm.pngfor MiqTemplate instances, but can you check please? Also, this should make it trivial to add fonticons to summaries :)