Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use react-codemirror onChange event instead of onBeforeChange. #6030

Merged
merged 1 commit into from Aug 16, 2019
Merged

Use react-codemirror onChange event instead of onBeforeChange. #6030

merged 1 commit into from Aug 16, 2019

Conversation

Hyperkid123
Copy link
Contributor

fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1740753

Trying to use different event handlers to make QE testing easier.

@Hyperkid123
Copy link
Contributor Author

cc @h-kataria

@miq-bot miq-bot added the wip label Aug 15, 2019
@lina-is-here
Copy link

+1 for that! Tried it locally and it saves us from changing properties on that page, so we can avoid weird workarounds.

@Hyperkid123
Copy link
Contributor Author

@lina-nikiforova is there anything else i can do for you?

@Hyperkid123
Copy link
Contributor Author

@miq-bot add_reviewer @rvsia
@miq-bot add_label react
@miq-bot remove_label wip
@miq-bot assign @h-kataria

@miq-bot miq-bot requested a review from rvsia August 15, 2019 14:05
@miq-bot miq-bot added the react label Aug 15, 2019
@miq-bot miq-bot changed the title [WIP] Use react-codemirror onChange event instead of onBeforeChange. Use react-codemirror onChange event instead of onBeforeChange. Aug 15, 2019
@miq-bot miq-bot removed the wip label Aug 15, 2019
@miq-bot
Copy link
Member

miq-bot commented Aug 15, 2019

Checked commit Hyperkid123@d7dec1a with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@h-kataria h-kataria added this to the Sprint 118 Ending Aug 19, 2019 milestone Aug 16, 2019
@h-kataria h-kataria merged commit 471bc69 into ManageIQ:master Aug 16, 2019
@Hyperkid123 Hyperkid123 deleted the tweak-react-code-editor branch August 16, 2019 08:03
@lina-is-here lina-is-here mentioned this pull request Aug 23, 2019
Merged
simaishi pushed a commit that referenced this pull request Sep 30, 2020
@h-kataria @simaishi
Merge pull request #6030 from Hyperkid123/tweak-react-code-editor
65e6529 
Use react-codemirror onChange event instead of onBeforeChange.

(cherry picked from commit 471bc69)

https://bugzilla.redhat.com/show_bug.cgi?id=1740753
@simaishi
Copy link
Contributor

Ivanchuk backport details:

$ git log -1
commit 65e652932510056e184c3b8f4ae20b4bbff6fe16
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Thu Aug 15 23:12:09 2019 -0400

    Merge pull request #6030 from Hyperkid123/tweak-react-code-editor

    Use react-codemirror onChange event instead of onBeforeChange.

    (cherry picked from commit 471bc696f27562e8c560b18a973b17ce7f009975)

    https://bugzilla.redhat.com/show_bug.cgi?id=1740753

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-kataria h-kataria h-kataria approved these changes

@rvsia rvsia Awaiting requested review from rvsia

Assignees

@h-kataria h-kataria

Labels
bug changelog/yes ivanchuk/backported react
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Hyperkid123 @lina-is-here @miq-bot @simaishi @h-kataria