Add titles for editor of service dialogs #6085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit rvsia@6bf2a76 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
h-kataria
approved these changes
Aug 23, 2019
simaishi
pushed a commit
that referenced
this pull request
Feb 27, 2020
Add titles for editor of service dialogs (cherry picked from commit 739bd12) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1805851
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1741241
Description
Service dialog editor do not have specific titles, so they cannot be displayed in the breadcrumbs.
This PR only adds titles, #6073 will show them in breadcrumbs.
Before
Edit/Add
After
Add
Editing
@miq-bot add_label bug, ivanchuk/yes, changelog/yes