Fixed to set saveable state regardless of number of items selected. #6113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting saveable state only when 1 item is selected for retirement was causing Save button to remain disabled when multiple items were selected for retirement. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1745984
|
Checked commit h-kataria@9f4cc72 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
mzazrivec
approved these changes
Aug 28, 2019
simaishi
pushed a commit
that referenced
this pull request
Aug 31, 2019
…ple_items_selected Fixed to set saveable state regardless of number of items selected. (cherry picked from commit c7dc961) https://bugzilla.redhat.com/show_bug.cgi?id=1745984
|
Ivanchuk backport details: |
h-kataria
deleted the
enable_save_button_when_multiple_items_selected
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting saveable state only when 1 item is selected for retirement was causing Save button to remain disabled when multiple items were selected for retirement.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1745984
before
after
