Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Service requests show none with "refresh" buttons instead of selected values #614

Merged
merged 3 commits into from
Mar 13, 2017

Conversation

eclarizio
Copy link
Member

@eclarizio eclarizio commented Mar 7, 2017

This change utilizes a new option :request_view to force values that are passed in to be shown on the request review screen instead of running through the dialog again when it doesn't need to.

This will need to be combined with this PR in the main repo. to fix this specific BZ.

https://bugzilla.redhat.com/show_bug.cgi?id=1428171

This is also a related BZ, where instead of seeing "" when nothing was picked, it was showing the first thing in the drop-down list: https://bugzilla.redhat.com/show_bug.cgi?id=1428133 This was a misunderstanding on my part, these BZs are not related.

/cc @gmcculloug, not sure who to assign to this one.
@miq-bot add_label euwe/yes, bug

@miq-bot
Copy link
Member

miq-bot commented Mar 8, 2017

Checked commits eclarizio/manageiq-ui-classic@133a3f5~...cea90f0 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 🏆

@gmcculloug
Copy link
Member

@eclarizio Please add before/after screenshots.

@dclarizio Dependent PR ManageIQ/manageiq#14219 is merged. Please review.

@eclarizio
Copy link
Member Author

eclarizio commented Mar 13, 2017

Before, notice the value says "<None>" even though I picked something when I submitted the dialog.
screen shot 2017-03-13 at 11 53 20 am

After, notice now it shows the value I picked (note that this does not correspond to the description of the drop-down, in this instance I think I picked "Three" but it ends up showing the actual value that was submitted, which was the integer 3).
screen shot 2017-03-13 at 11 54 52 am

@dclarizio dclarizio merged commit f1ed389 into ManageIQ:master Mar 13, 2017
@dclarizio dclarizio added this to the Sprint 56 Ending Mar 13, 2017 milestone Mar 13, 2017
@simaishi
Copy link
Contributor

Euwe backport (to manageiq repo) details:

$ git log -1
commit 43c1816332f775e912b405f497cf1cf5f82307d3
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Mon Mar 13 13:19:08 2017 -0700

    Merge pull request #614 from eclarizio/BZ1428171
    
    Fix for Service requests show none with "refresh" buttons instead of selected values
    (cherry picked from commit f1ed389bf94df35e5cdd448067d96b2f81a9d7bf)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1431842

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants