Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option of copying tags #6164

Merged
merged 1 commit into from Sep 9, 2019

Conversation

astrozzc
Copy link
Contributor

@astrozzc astrozzc commented Sep 8, 2019

When catalog item is copied, the default behavior does
not copy tags. This PR adds an option of copying tags.

RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1740399
Depends on #19206

@miq-bot assign @h-kataria
@miq-bot add_label enhancement, ivanchuk/yes, changelog/yes
@miq-bot add_reviewer @ZitaNemeckova

When catalog item is copied, the default behavior does
not copy tags. This PR adds an option of copying tags.

RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1740399
Depends on #19206
@astrozzc
Copy link
Contributor Author

astrozzc commented Sep 8, 2019

@miq-bot add_reviewer @ZitaNemeckova

@miq-bot
Copy link
Member

miq-bot commented Sep 8, 2019

Checked commit astrozzc@6d7e6ff with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@astrozzc astrozzc marked this pull request as ready for review September 8, 2019 03:10
@martinpovolny
Copy link

Looks good! Can you, please add a screenshot?

@astrozzc
Copy link
Contributor Author

astrozzc commented Sep 9, 2019

@martinpovolny Sure, pls check the image below. Thanks!

Screen Shot 2019-09-09 at 10 54 36 AM

@martinpovolny martinpovolny self-assigned this Sep 9, 2019
@martinpovolny martinpovolny merged commit 60d78c9 into ManageIQ:master Sep 9, 2019
@martinpovolny martinpovolny added this to the Sprint 120 Ending Sep 16, 2019 milestone Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants