Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix traceback in edit report preview #6182

Merged
merged 1 commit into from Sep 12, 2019
Merged

Fix traceback in edit report preview #6182

merged 1 commit into from Sep 12, 2019

Conversation

mzazrivec
Copy link
Contributor

@mzazrivec mzazrivec commented Sep 12, 2019 •
edited

This is to fix traceback caused by b74c4a5#diff-a31349b4cac8623f48847e8d969ecbeaL53

  1. Overeview ➛ Reports ➛ Reports ➛ Select a report ➛ Edit that report ➛ Preview tab
  2. Observe the following traceback in logs:
[----] F, [2019-09-11T13:50:40.491791 #7953:2b01517a57ec] FATAL -- : Error caught: [RuntimeError] Graph type not specified
/opt/rh/cfme-gemset/bundler/gems/cfme-ui-classic-4de7acd5caeb/lib/report_formatter/chart_common.rb:16:in `build_document_header'
/opt/rh/cfme-gemset/bundler/gems/cfme-ui-classic-4de7acd5caeb/lib/report_formatter/c3.rb:56:in `build_document_header'
/opt/rh/cfme-gemset/bundler/gems/ruport-3727775479b0/lib/ruport/controller.rb:598:in `maybe'
/opt/rh/cfme-gemset/bundler/gems/ruport-3727775479b0/lib/ruport/controller.rb:584:in `block in execute_stages'
/opt/rh/cfme-gemset/bundler/gems/ruport-3727775479b0/lib/ruport/controller.rb:583:in `each'
/opt/rh/cfme-gemset/bundler/gems/ruport-3727775479b0/lib/ruport/controller.rb:583:in `execute_stages'
/opt/rh/cfme-gemset/bundler/gems/ruport-3727775479b0/lib/ruport/controller.rb:574:in `_run_'
/opt/rh/cfme-gemset/bundler/gems/ruport-3727775479b0/lib/ruport/controller.rb:520:in `run'
/opt/rh/cfme-gemset/bundler/gems/ruport-3727775479b0/lib/ruport/controller.rb:436:in `render'
/var/www/miq/vmdb/app/models/miq_report/formatters/graph.rb:13:in `to_chart'
/opt/rh/cfme-gemset/bundler/gems/cfme-ui-classic-4de7acd5caeb/app/controllers/report_controller/reports.rb:55:in `show_preview'
/opt/rh/cfme-gemset/bundler/gems/cfme-ui-classic-4de7acd5caeb/app/controllers/application_controller/wait_for_task.rb:23:in `wait_for_task'

https://bugzilla.redhat.com/show_bug.cgi?id=1751328

@miq-bot
Copy link
Member

miq-bot commented Sep 12, 2019

Checked commit mzazrivec@60e3003 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@h-kataria h-kataria self-assigned this Sep 12, 2019
@h-kataria h-kataria added this to the Sprint 120 Ending Sep 16, 2019 milestone Sep 12, 2019
@h-kataria h-kataria merged commit 037160f into ManageIQ:master Sep 12, 2019
@mzazrivec mzazrivec deleted the fix_traceback_in_edit_report_preview branch September 13, 2019 06:58
simaishi pushed a commit that referenced this pull request Oct 31, 2019
@h-kataria @simaishi
Merge pull request #6182 from mzazrivec/fix_traceback_in_edit_report_…
4bdd524 
…preview

Fix traceback in edit report preview

(cherry picked from commit 037160f)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1767659
@simaishi
Copy link
Contributor

Ivanchuk backport details:

$ git log -1
commit 4bdd5240e19076a14b2ce378d53c77b52bd369c6
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Thu Sep 12 12:01:23 2019 -0400

    Merge pull request #6182 from mzazrivec/fix_traceback_in_edit_report_preview
    
    Fix traceback in edit report preview
    
    (cherry picked from commit 037160ffac42d9753e19f1609722a459839cdc9b)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1767659

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-kataria h-kataria h-kataria approved these changes

Assignees

@h-kataria h-kataria

Labels
blocker bug changelog/yes ivanchuk/backported overview/reporting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mzazrivec @miq-bot @simaishi @h-kataria