New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tagging for Edit Group and Provisioning screens #6235
Fix tagging for Edit Group and Provisioning screens #6235
Conversation
@PanSpagetka I've tested changes in this PR but I am still getting the same error, when adding some tag under My Company Tags tab when adding/editing a Group:
And for Purpose tab, it does not work, too. After I choose some value from the drop down, assigned tag displays for a second and then it suddenly disappears in front of my eyes and "No Assigned Tags" is displayed instead. Am I doing anything wrong while testing this PR? Do I need to do any extra steps before testing the scenarios? Thanks. |
Ehm, sorry, you need ManageIQ/react-ui-components#152 I will mark it more clearly in description |
@PanSpagetka So finally, ManageIQ/react-ui-components#152 is merged but I am still getting errors. Am I missing something? |
23fd121
to
8f3c52a
Compare
@hstastna I had to update package.json in this PR, now it should be finally working |
8f3c52a
to
a82f8fe
Compare
Checked commits PanSpagetka/manageiq-ui-classic@be384d4~...a82f8fe with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
So for proper testing, it is good to remove node_modules from manageiq-ui-classic and to run |
@miq-bot remove_label unmergeable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding tags works fine ✨ in both places (for Groups and also for Purpose tab), no errors.
However, it works differently in each of these places: While adding/editing a Group, I can select more values for the same Category, but under Purpose tab, I simply cannot. If I try to do it, the existing value is rewritten with the new one. Is this intentional? Thanks.
@hstastna Thanks for testing. Yes, this is intentional. For Add/Edit group you can add more tags, but for the Provisioning -> Purpose you can't. |
Because of changes in ManageIQ/react-ui-components#132 tagging wasn't working properly for Edit Group and Provisioning screens.
Links [Optional]
ManageIQ/react-ui-components#132
ManageIQ/react-ui-components#152 NEEDED TO BE MERGED FIRST
#5946
Steps for Testing/QA [Optional]
Compute -> Cloud -> Instance -> Lifecycle -> Provision -> Purpose tab
Cog wheel in the right corner -> Access Control -> Groups -> Edit some group