Convert part of Infra Provider dashboard to React, add Quadicon. #6248
Conversation
martinpovolny
force-pushed
the
infra_dash
branch
from
94450e8
to
8cc3308
Compare
martinpovolny
changed the title
martinpovolny
changed the title
miq-bot
changed the title
Except for the quadicon which is a standard quadicon w/o any modifications. |
| const url = `/${providerType}_dashboard/aggregate_status_data/${providerId || ''}`; | ||
| http.get(url) | ||
| .then((response) => { | ||
| console.log(response.data); |
There was a problem hiding this comment.
@martinpovolny the console.log() is left there intentionally?
martinpovolny
force-pushed
the
infra_dash
branch
from
4170c54
to
40fb0d1
Compare
|
|
||
| PfAggregateStatusCard.defaultProps = { | ||
| layout: null, | ||
| className: null, // bylo to tam? |
There was a problem hiding this comment.
This comment needs to go away.
| className: null, // bylo to tam? | ||
| data: {}, | ||
| altLayout: false, | ||
| showTopBorder: false, // urcite? |
| @@ -58,6 +62,7 @@ ManageIQ.component.addReact('MiqAboutModal', MiqAboutModal); | |||
| ManageIQ.component.addReact('OptimizationList', OptimizationList); | |||
| ManageIQ.component.addReact('OpsTenantForm', OpsTenantForm); | |||
| ManageIQ.component.addReact('OrcherstrationTemplateForm', OrcherstrationTemplateForm); | |||
| ManageIQ.component.addReact('Quadicon', Quadicon); | |||
There was a problem hiding this comment.
This should probably come after PxeServersForm (if we want to do this alphabetically).
|
This is what I get when I navigate to physical infra details screen EDIT: after server restart, the problem shown above went away 🤷 |
|
@mzazrivec : fixed the issues. The failure does not seem related. |
|
Checked commits martinpovolny/manageiq-ui-classic@2b617b7~...ab30cdd with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
https://bugzilla.redhat.com/show_bug.cgi?id=1542736
TODO:
Remove obsolete Angular files(probably not as part of this PR as they seem to be used elsewhere)Add specs.