Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading of Network Port details screen #6277

Merged
merged 1 commit into from Oct 8, 2019

Conversation

h-kataria
Copy link
Contributor

@h-kataria h-kataria commented Oct 7, 2019

When Network Port has a device of type LoadBalancer, loading of details screen throws a missing route error because LoadBalancer views no longer exist in UI. This change shows LoadBalancer information as a static name instead of a link.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1758593

before
before

after
after

When Network Port has a device of type LoadBalancer, loading of details screen throws a missing route error because LoadBalancer views no longer exist in UI. This change shows LoadBalancer information as a static name instead of a link.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1758593
@miq-bot
Copy link
Member

miq-bot commented Oct 7, 2019

Checked commit h-kataria@09231fa with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 👍

@mzazrivec mzazrivec self-assigned this Oct 8, 2019
@mzazrivec mzazrivec added this to the Sprint 122 Ending Oct 14, 2019 milestone Oct 8, 2019
@mzazrivec mzazrivec merged commit f10324a into ManageIQ:master Oct 8, 2019
simaishi pushed a commit that referenced this pull request Nov 1, 2019
Fix loading of Network Port details screen

(cherry picked from commit f10324a)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1767809
@simaishi
Copy link
Contributor

simaishi commented Nov 1, 2019

Ivanchuk backport details:

$ git log -1
commit 8785863268da7fce117f908f21846480af4c1b35
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Tue Oct 8 12:04:01 2019 +0200

    Merge pull request #6277 from h-kataria/fix_netowrk_port_summary
    
    Fix loading of Network Port details screen
    
    (cherry picked from commit f10324a3f6cd0f9e3f28e0414de499281307c55c)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1767809

@h-kataria h-kataria deleted the fix_netowrk_port_summary branch February 25, 2020 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants