Show name in success catalog form messages #6352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit rvsia@d111a71 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
The CI failure is in master too, not caused by this PR. (Should be fixed by #6353 ) |
ZitaNemeckova
approved these changes
Nov 5, 2019
simaishi
pushed a commit
that referenced
this pull request
Dec 16, 2019
Show name in success catalog form messages (cherry picked from commit aa9be06) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1784187
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1766276
Steps to Reproduce:
1.Go to Services -> Catalogs -> Catalogs accordion
2.Add or Update a catalog
3.View the success message
Actual results:
Catalog was saved
Expected results:
Catalog "{catalog_name}" was saved
Before
After
@miq-bot add_label bug, ivanchuk/yes, changelog/yes
@h-kataria