Fix double ng-if #6382
Merged
Fix double ng-if #6382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
@tinaafitz @lfu Can one of you verify if "Hosts" field should be visible for Playbook methods? I think changes in #5295 were added to support playbook type automate methods so we should go with the field being visible. what do you think? |
|
|
Remove check "#{ng_model}.#{prefix}_inventory!==undefined" as it's always set for Ansible Playbook and "#{ng_model}.location==='playbook'" makes sure it's not shown for other methods/catalog items
ZitaNemeckova
force-pushed
the
fix_ng_if
branch
from
aefc299
to
03bbb70
Compare
|
Checked commit ZitaNemeckova@03bbb70 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot remove_label wip @lfu Thanks :) Fixed accordingly. @h-kataria please have a look, thanks :) |
|
CI failure #4921 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@miq-bot add_label wip, cleanup, ivanchuk/no
Fix following error in spec log:
Places to check it works:
Services -> Catalogs -> Catalog Items -> create/edit -> Hosts show only for Ansible Playbook
Automation -> Automate -> Explorer -> create/edit a method -> Hosts show only for Ansible Playbook
Hosts pic:
Remove check
"#{ng_model}.#{prefix}_inventory!==undefined"as it's always set for Ansible Playbook and"#{ng_model}.location==='playbook'"makes sure it's not shown for other methods/catalog items.