[HAMMER] DialogUser - use DialogData.outputConversion before submit and refresh #6415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@himdel The current CI failures seem related. |
|
Ah, we don't have object.values shimmed in hammer, looking :) |
right now, when submitting a service dialog, we simply take the dialogData object, convert to JSON and send to the API. To allow for output conversions, adding a DialogData.outputConversion method, which should return the dialogData in a suitable format. (Right now, all this really means is that it converts Dates to strings before JSON stringification.) https://bugzilla.redhat.com/show_bug.cgi?id=1744413 (cherry picked from commit 8261b82)
… unify with SUI also, we can get rid of the API angular promise to Promise conversion with the $scope.$apply() removal in dialogUser.ts in ui-components https://bugzilla.redhat.com/show_bug.cgi?id=1744413 (cherry picked from commit 178a283)
(cherry picked from commit 7a3ae03)
…a being a string and a surprising promise mock (cherry picked from commit d46b0ad)
just for the specs, we don't support browsers without it
|
Checked commits https://github.com/himdel/manageiq-ui-classic/compare/40b825d55b3b6661b73faaf674efe201a64158af~...57a6c8129d37d109688626996833dc6fe26fd4fb with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Whew, |
mzazrivec
approved these changes
Nov 18, 2019
martinpovolny
approved these changes
Nov 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hammer version of #6291
Depends on #6408 (merged and rebased)(there was a conflict with dependency injection in dialog_user - there is no
dialogReplaceDatain hammer)Depends on ManageIQ/ui-components#422
Right now, when submitting a service dialog,
we simply take the dialogData object, convert to JSON and send to the API.
To allow for output conversions, adding a DialogData.outputConversion method,
which should return the dialogData in a suitable format.
(Right now, all this really means is that it converts Dates to strings before JSON stringification.)
And the same needs to happen in refreshField for dynamic fields.
https://bugzilla.redhat.com/show_bug.cgi?id=1744413
@miq-bot add_label bug