Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move $().setupVerticalNavigation(...) logic to React #6463

Merged
merged 21 commits into from Dec 5, 2019
Merged

Move $().setupVerticalNavigation(...) logic to React #6463

merged 21 commits into from Dec 5, 2019

Commits on Dec 4, 2019

  1. Convert vertical-navbar levels expanding to React 

    Disable setupVerticalNavigation() and convert expanding logic to React.
    @fhlavac
    fhlavac committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    d794a15 View commit details
    Browse the repository at this point in the history

  2. Update snapshot after converting expanding logic

    @fhlavac
    fhlavac committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    e8d5430 View commit details
    Browse the repository at this point in the history

  3. Replace navbar-header with empty partial

    @fhlavac
    fhlavac committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    78e3228 View commit details
    Browse the repository at this point in the history

  4. Add NavbarHeader component design implementation

    @fhlavac
    fhlavac committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    0511504 View commit details
    Browse the repository at this point in the history

  5. Move navbar-header component to top-navbar dir

    @fhlavac
    fhlavac committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    d74d567 View commit details
    Browse the repository at this point in the history

  6. Create menu-reducer for navbar collapsed state

    @fhlavac
    fhlavac committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    fe5dc1e View commit details
    Browse the repository at this point in the history

  7. Fix content resizing when vertical-nav collapsed

    @fhlavac
    fhlavac committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    1d89099 View commit details
    Browse the repository at this point in the history

  8. Delete vertical navbar item pinning

    @fhlavac
    fhlavac committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    003badf View commit details
    Browse the repository at this point in the history

  9. Clean classNames using clsx

    @fhlavac
    fhlavac committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    852b0aa View commit details
    Browse the repository at this point in the history

  10. Add tests for vertical-nav collapsing using Redux

    @fhlavac
    fhlavac committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    d2a8832 View commit details
    Browse the repository at this point in the history

  11. Shorten lines in vertical-nav tests

    @fhlavac
    fhlavac committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    e84d60c View commit details
    Browse the repository at this point in the history

  12. Delete setupVerticalNavigation()

    @fhlavac
    fhlavac committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    ff6f654 View commit details
    Browse the repository at this point in the history

  13. Remove styling for menu-item pinning

    @fhlavac
    fhlavac committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    9650d2f View commit details
    Browse the repository at this point in the history

  14. Move hooks definitions to the top of the function

    @fhlavac
    fhlavac committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    bd734f0 View commit details
    Browse the repository at this point in the history

  15. Update className for top-level-item

    @fhlavac
    fhlavac committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    8dc77df View commit details
    Browse the repository at this point in the history

  16. Replace 'clsx' package usage with 'classnames'

    @fhlavac
    fhlavac committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    31b9bc4 View commit details
    Browse the repository at this point in the history

  17. Verify content element existence before using it

    @fhlavac
    fhlavac committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    eefb30c View commit details
    Browse the repository at this point in the history

  18. Add object destructuring to navbar-header

    @fhlavac
    fhlavac committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    7e28be0 View commit details
    Browse the repository at this point in the history

  19. Rename 'reducer' to 'menuReducer'

    @fhlavac
    fhlavac committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    830e454 View commit details
    Browse the repository at this point in the history

  20. Add 'navbar.' prefix to NavbarHeader 

    in component-definitions-common.js
    @fhlavac
    fhlavac committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    4afbcfb View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2019

  1. Preserve collapsed state using Local Storage

    @fhlavac
    fhlavac committed Dec 5, 2019
    Configuration menu
    Copy the full SHA
    11c062d View commit details
    Browse the repository at this point in the history