Hide Advanced Search in Config Mgmt Providers screen #6465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug |
hstastna
force-pushed
the
Config_Managers_Ansible_Satellite_Adv_search
branch
6 times, most recently
from
aa577d4
to
16392fb
Compare
hstastna
force-pushed
the
Config_Managers_Ansible_Satellite_Adv_search
branch
2 times, most recently
from
4edcfcf
to
e066278
Compare
hstastna
changed the title
hstastna
force-pushed
the
Config_Managers_Ansible_Satellite_Adv_search
branch
3 times, most recently
from
1af6313
to
fff73a6
Compare
hstastna
force-pushed
the
Config_Managers_Ansible_Satellite_Adv_search
branch
from
fff73a6
to
c3a2194
Compare
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1777493 Prevent unnecessary call and fix appearing Adv Search in Config Mgmt Providers accordion which is not supported there. Add replace_search_box method to the two controllers to update_partials method where it is missing.
hstastna
force-pushed
the
Config_Managers_Ansible_Satellite_Adv_search
branch
from
c3a2194
to
65155b5
Compare
|
Checked commits hstastna/manageiq-ui-classic@8b60627~...65155b5 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@h-kataria @martinpovolny @ZitaNemeckova Could you, please, review this? Thanks in advance :) |
simaishi
pushed a commit
that referenced
this pull request
Feb 21, 2020
…ite_Adv_search Hide Advanced Search in Config Mgmt Providers screen (cherry picked from commit f27b5d8) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1805804
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1777493
This PR:
replace_search_boxmethod in ManagerControllerMixin inreplace_right_cellmethod, especially forprovider_foremanandautomation_managercontrollers - this change fixes appearing Adv Search in Config > Mgmt > Providers accordion which is not supported there, so it does not appear there anymore, and it works for any item in the tree in Providers accordion in the appropriate screenreplace_search_boxmethod toinfra_networkingcontrollers toupdate_partialsmethod where it is missing - according to the removing the method from ManagerControllerMixin => with such changes we avoid adding extra conditions inreplace_right_cellin ManagerControllerMixin :) (instoragecontroller, no need to addreplace_search_box, see the code)replace_search_boxmethod (because doing anything withlayouts/adv_searchdoes not make sense if we don't want to render Adv Search at all, andlocals[:nameonly]"decides" if Adv Search will or will not be displayed), also makes Search field to appear and work thereprovider_active_tree?where it is possible, inprovider_foremancontroller, to simplify the code little bitBefore:
Adv Search appears, after step 3 (see the BZ):
After clicking on another item in accordion:
After:
