Fix breaking VMs page after closing user input dialog #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug, ui |
|
@hstastna verified fix in UI, you think you can add a spec test around this method. |
|
@hstastna see @h-kataria's comment above. |
|
@h-kataria @dclarizio I can add a spec test if needed. But maybe this can be merged and at least, it will work. And a spec test can be in another PR. Or do we need it in this PR? |
|
@hstastna since this is not high pri. BZ i suggest adding spec test in this PR itself. Let me know if you need help with spec test. |
hstastna
force-pushed
the
Search_field_user_input_dialog_VMs
branch
from
b0127fc
to
166e7ae
Compare
|
@h-kataria I've added a spec test in this PR. |
fixing https://bugzilla.redhat.com/show_bug.cgi?id=1425840 Fix breaking VMs page after closing user input dialog and clicking view selector after creating a filter in Advanced search in Compute->Infrastructure->Virtual Machines, VMs or Templates accordion.
hstastna
force-pushed
the
Search_field_user_input_dialog_VMs
branch
from
166e7ae
to
735529e
Compare
|
Checked commits hstastna/manageiq-ui-classic@b2de84b~...735529e with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Euwe backport (to manageiq repo) details: |
simaishi
pushed a commit
that referenced
this pull request
Aug 9, 2017
Fix breaking VMs page after closing user input dialog (cherry picked from commit 7986de6) https://bugzilla.redhat.com/show_bug.cgi?id=1479941
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing https://bugzilla.redhat.com/show_bug.cgi?id=1425840
Fix breaking VMs page after closing user input dialog
and clicking view selector after creating a filter
in Advanced search in Compute->Infrastructure->Virtual Machines,
VMs or Templates accordion.
After this fix:
Virtual Machines page doesn't break anymore.
Search field doesn't disappear anymore.
View Selector control doesn't break in Templates view.
Advanced search button appears after changing view normally.
The problem was:
x_rootchanged value from"root"tonilinquick_search_cancel_clickmethodwhen clicked on "Cancel" button in user input dialog.
I think that there is some reason for this, but as I was exploring,
x_roothad value"root"in the method whether any filter was applied or not,in other working pages. The value affects the proper view
of the page when changing the view.
Before:
After:
