Allow advanced modifications of Amazon cloud volumes #676
Conversation
|
@AparnaKarve this is the form I talked about yesterday. Although it depends on the Amazon provider changes, I would appreciate any feedback. |
| @@ -14,7 +14,7 @@ ManageIQ.angular.app.controller('cloudVolumeFormController', ['$http', '$scope', | |||
| { type: "io1", name: "Provisioned IOPS SSD (IO1)" }, | |||
| { type: "st1", name: "Throughput Optimized HDD (ST1)" }, | |||
| { type: "sc1", name: "Cold HDD (SC1)" }, | |||
| { type: "magnetic", name: "Magnetic" }, | |||
| { type: "standard", name: "Magnetic" }, | |||
There was a problem hiding this comment.
Would have really liked if we could fetch this list on-the-fly using some API (AWS API perhaps?)
But don't worry about it, if that's not doable.
There was a problem hiding this comment.
AWS does not provide an API for this; we initially thought about making CloudVolumeType model where storage managers would be able to list their options (for example in OpenStack admins are allowed to define different volume types so it would make sense).
My concern is that there are specific rules in the UI that need to be handled with regards to the chosen volume type, so I am not sure if providing it through API/backend would benefit much. Still, we could use something like this for regions or instance types. Would that make any sense?
There was a problem hiding this comment.
Sure, yes. I know you mentioned this even before.
| @@ -0,0 +1,60 @@ | |||
| .form-group{"ng-class" => "{'has-error': angularForm.name.$invalid}"} | |||
There was a problem hiding this comment.
Can you rename this haml to _form.html.haml?
There was a problem hiding this comment.
Yes, I missed that completely.
| 'ng-maxlength' => 128, | ||
| :miqrequired => false, | ||
| :checkchange => true} | ||
| = render :partial => "common_new_edit" | ||
|
|
||
| %table{:width => '100%'} | ||
| %tr |
There was a problem hiding this comment.
In this haml, down below, can you use this partial to render the buttons?
"layouts/angular/x_edit_buttons_angular"
instead of rendering the buttons individually.
(I probably missed telling you this in your earlier PR)
There was a problem hiding this comment.
Yes, sure - I didn't know about this before.
There was a problem hiding this comment.
@AparnaKarve I noticed there are some differences between the way how the button table is created for "new volume" than in the about partial layout. For example, in cloud volume case it checks if @volume.id.nil? to decide whether to show Add or Save, while the layout partial uses newRecord.
I guess we should update the whole controller/view to make it compliant with the partial layout. Perhaps in a separate PR. What do you think?
| :checkchange => true} | ||
| %span.help-block{"ng-show" => "cloudVolumeModel.aws_volume_type == 'io1' && angularForm.aws_iops.$error.required"} | ||
| = _("Required") | ||
| = render :partial => "common_new_edit" | ||
|
|
There was a problem hiding this comment.
Same comment as above for the button partial
|
@gberginc I have tested this in the UI and it works great! |
| $scope.cloudVolumeModel.size = data.size; | ||
| // Currently, this is only relevant for AWS volumes so we are prefixing the | ||
| // model attribute with AWS. | ||
| $scope.cloudVolumeModel.aws_volume_type = data.volume_type; |
There was a problem hiding this comment.
@gberginc We now have REST API support for the cloud_volumes collection...which means we can get rid of this $http.get call here and replace it with --
/api/cloud_volumes/<id>?attributes=ext_management_system.type
gberginc
force-pushed
the
cloud_volume_update
branch
from
70afb22
to
a68b2a0
Compare
Amazon EBS has recently introduced ability to modify cloud volume configuration (type of cloud volume, its size and the IOPS). This patch reuses the UI from the cloud volume creation dialog to allow users to modify volumes on the fly.
gberginc
force-pushed
the
cloud_volume_update
branch
from
a68b2a0
to
b3527cc
Compare
|
@AparnaKarve I've renamed the haml file, replaced I am not sure about the buttons at the bottom if it makes sense to change it within this PR, so I'd appreciate your feedback. |
|
Checked commit gberginc@b3527cc with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/views/cloud_volume/_common_new_edit.html.haml
|
Awesome! I reviewed that part and it looks good.
A separate follow-up PR later should be fine. Not a problem. |
|
@AparnaKarve is there anything more to change in this one? |
|
@gberginc I think everything is addressed here other than the buttons, but there will be a follow-up PR for that. @h-kataria Can you please merge this? |
Amazon EBS has recently introduced ability to modify cloud volume
configuration (type of cloud volume, its size and the IOPS). This patch
reuses the UI from the cloud volume creation dialog to allow users to
modify volumes on the fly.
Depends on
Video: http://x.k00.fr/7t19f
@miq-bot add_label enhancement, storage