Fixed some issues introduced with retirement remove resources option #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 This is working for me. Thanks |
h-kataria
force-pushed
the
catalog_item_fixes
branch
from
368c68c
to
7bc7ef4
Compare
h-kataria
changed the title
h-kataria
force-pushed
the
catalog_item_fixes
branch
2 times, most recently
from
3628ec9
to
3be3e54
Compare
h-kataria
force-pushed
the
catalog_item_fixes
branch
from
3be3e54
to
af49252
Compare
- Also replaced .find calls with .find_by. - Fixed broken spec tests with recent changes. https://www.pivotaltracker.com/story/show/141238703
h-kataria
force-pushed
the
catalog_item_fixes
branch
from
af49252
to
25f8cda
Compare
|
Checked commit h-kataria@25f8cda with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/controllers/catalog_controller.rb
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also replaced .find calls with .find_by.
@gmcculloug please test for issues found during catalog item edit.
@lgalis is looking into fixing save button being enabled on initial load of edit form in a separate PR.