Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed miq policy profile onclick in the policy profile list #702

Merged
merged 1 commit into from Mar 16, 2017

Conversation

skateman
Copy link
Member

@skateman skateman commented Mar 16, 2017

Policy profiles list items weren't clickable under: Control -> Explorer -> Policy Profiles
Regression caused by: e6c24c6#diff-b27309c027e5c4dadd975646b8a8189dR15
Following rubocop's suggestions isn't always the Right Way™ 😉

@miq-bot
Copy link
Member

miq-bot commented Mar 16, 2017

Some comments on commit skateman@a9c72d7

app/views/miq_policy/_profile_list.html.haml

  • ⚠️ - 15 - Detected pp. Remove all debugging statements.

@miq-bot
Copy link
Member

miq-bot commented Mar 16, 2017

Checked commit skateman@a9c72d7 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. ⭐

@miq-bot miq-bot removed the euwe/yes label Mar 16, 2017
@martinpovolny martinpovolny added this to the Sprint 57 Ending Mar 27, 2017 milestone Mar 16, 2017
@martinpovolny martinpovolny merged commit 0228382 into ManageIQ:master Mar 16, 2017
@skateman skateman deleted the policy-profile-prefix branch March 16, 2017 10:56
@skateman
Copy link
Member Author

This issue is also happening on euwe, so adding the flag:
@miq-bot add_label euwe/yes

@simaishi
Copy link
Contributor

@skateman Is there a BZ for this? Can you please create if it doesn't exist?

@skateman
Copy link
Member Author

@simaishi
Copy link
Contributor

Euwe backport (to manageiq repo) details:

$ git log -1
commit ad2a381ff4a094ed462c9cfe0f4e3dd9189c57e5
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Thu Mar 16 11:54:04 2017 +0100

    Merge pull request #702 from skateman/policy-profile-prefix
    
    Fixed miq policy profile onclick in the policy profile list
    (cherry picked from commit 0228382535af8b2329182769098bf8693bbda17a)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1433976

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants