Replace the old network provider forms with the DDF-based ProviderForm #7090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gubbe505 this should simplify the UI a little for the NSX-T provider as well |
|
Checked commit skateman@eb52249 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint app/views/ems_network/edit.html.haml
app/views/ems_network/new.html.haml
|
himdel
approved these changes
Jun 22, 2020
37 tasks
|
Dependencies resolved, this is good to go @h-kataria @himdel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
Fixes: #6873
Depends on: ManageIQ/manageiq-providers-nuage#214
Parent issue: ManageIQ/manageiq#18818