Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable privilege escalation when machine credential doesn't support it #7095

Conversation

mzazrivec
Copy link
Contributor

@mzazrivec mzazrivec commented Jun 2, 2020

  1. Attempt to create a Ansible Playbook service
  2. Select repository and a playbook
  3. Select a machine credential without privilege escalation method
  4. Select a different machine credential with privilege escalation method

In both cases (3 & 4) the Privilege Escalation switch stays visible & usable. In truth, the switch should be enabled only for machine credentials actually supporting privilege escalation.

When selected a machine credential that supports privilege escalation:
Screenshot from 2020-06-02 16-10-43

When selected a machine credential that doesn't support privilege escalation:
Screenshot from 2020-06-02 16-11-09

https://bugzilla.redhat.com/show_bug.cgi?id=1810477

@miq-bot
Copy link
Member

miq-bot commented Jun 2, 2020

Checked commit mzazrivec@1959a15 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
1 file checked, 2 offenses detected

app/views/layouts/angular/_ansible_form_options_angular.html.haml

  • ⚠️ - Line 185 - Line is too long. [271/160]
  • ⚠️ - Line 185 - id attribute must be in lisp-case

@h-kataria h-kataria self-assigned this Jun 3, 2020
@h-kataria h-kataria merged commit 23efdfc into ManageIQ:master Jun 3, 2020
@mzazrivec mzazrivec deleted the disable_privilege_escalation_when_needed branch June 4, 2020 08:55
simaishi pushed a commit that referenced this pull request Jun 5, 2020
…when_needed

Disable privilege escalation when machine credential doesn't support it

(cherry picked from commit 23efdfc)
@simaishi
Copy link
Contributor

simaishi commented Jun 5, 2020

Jansa backport details:

$ git log -1
commit cf834f48fe5eb454baf289b345aed6e2cd21c688
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Wed Jun 3 14:09:07 2020 -0400

    Merge pull request #7095 from mzazrivec/disable_privilege_escalation_when_needed

    Disable privilege escalation when machine credential doesn't support it

    (cherry picked from commit 23efdfcd03c7e72d7623ac3c0d4d33bfe6ad25a8)

simaishi pushed a commit that referenced this pull request Jun 18, 2020
…when_needed

Disable privilege escalation when machine credential doesn't support it

(cherry picked from commit 23efdfc)

https://bugzilla.redhat.com/show_bug.cgi?id=1810477
@simaishi
Copy link
Contributor

Ivanchuk backport details:

$ git log -1
commit 0d720cc456f05182b94fee62a71cbd151935bf11
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Wed Jun 3 14:09:07 2020 -0400

    Merge pull request #7095 from mzazrivec/disable_privilege_escalation_when_needed

    Disable privilege escalation when machine credential doesn't support it

    (cherry picked from commit 23efdfcd03c7e72d7623ac3c0d4d33bfe6ad25a8)

    https://bugzilla.redhat.com/show_bug.cgi?id=1810477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants