Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ad-hoc page css for new Patternfly version #826

Merged

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Mar 28, 2017

Description
#402 updated the Patternfly version in ManageIQ, this PR has some little css fixes for the ad-hoc page.

Screenshot
Broken
screenshot-localhost 3000-2017-03-28-17-56-40

Fixed css
screenshot-localhost 3000-2017-03-29-16-55-42

@miq-bot miq-bot added the wip label Mar 28, 2017
@yaacov
Copy link
Member Author

yaacov commented Mar 28, 2017

@miq-bot add_label compute/containers

@himdel @jeff-phillips-18 help , I do not understand why the filter's main select widget doesn't work here, any idea ?

All dropdown works except the main filter dropdown, the little border under the button is connected with the items list (ul element with the items that should show when button is pressed):
gifrecord_2017-03-28_180430

cc @simon3z

p.s.
@moolitayer I think the alerts page is also broken, can you rebase and check ?

@yaacov
Copy link
Member Author

yaacov commented Mar 29, 2017

@skateman ping, hi, can you help with the pfFilter thing ?

patternfly examples working (has class="dropdown"):
screenshot from 2017-03-29 12-06-37

manageiq not working (does not have class="dropdown"):
screenshot from 2017-03-29 12-06-46

@yaacov
Copy link
Member Author

yaacov commented Mar 29, 2017

note: the pfFilter is broken in the alerts page too

cc @moolitayer

@yaacov yaacov force-pushed the fix-new-patternfly-regresions-in-ad-hoc-page branch from 80f04e1 to 8eb284a Compare March 29, 2017 13:55
@yaacov yaacov changed the title [WIP] Fix ad-hoc page css for new Patternfly version Fix ad-hoc page css for new Patternfly version Mar 29, 2017
@miq-bot miq-bot removed the wip label Mar 29, 2017
@yaacov yaacov force-pushed the fix-new-patternfly-regresions-in-ad-hoc-page branch from 8eb284a to 9504492 Compare March 29, 2017 14:10
@yaacov
Copy link
Member Author

yaacov commented Mar 29, 2017

removed wip

@simon3z @zakiva @himdel please review

@yaacov yaacov force-pushed the fix-new-patternfly-regresions-in-ad-hoc-page branch from 9504492 to 64018fc Compare March 29, 2017 14:17
@miq-bot
Copy link
Member

miq-bot commented Mar 29, 2017

Checked commit yaacov@64018fc with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks good. 🍰

@yaacov
Copy link
Member Author

yaacov commented Mar 29, 2017

@miq-bot add_label bug

@miq-bot miq-bot added the bug label Mar 29, 2017
@yaacov
Copy link
Member Author

yaacov commented Mar 30, 2017

@himdel please review

here is a provider for testing:
https://github.com/yaacov/miq-scripts/blob/master/set-miq-providers.rb is updated with updated token, the first provider in this list is working again.

@himdel
Copy link
Contributor

himdel commented Mar 30, 2017

Aah, looks much better, thanks! :)

Merging..

@himdel himdel merged commit 99f6d78 into ManageIQ:master Mar 30, 2017
@himdel himdel added this to the Sprint 58 Ending Apr 10, 2017 milestone Mar 30, 2017
@himdel himdel self-assigned this Mar 30, 2017
@yaacov
Copy link
Member Author

yaacov commented Mar 30, 2017

@miq-bot add_label euwe/no, fine/yes

@yaacov
Copy link
Member Author

yaacov commented Mar 30, 2017

@himdel we need this is fine, because the bad layout is in fine.

simaishi pushed a commit that referenced this pull request Mar 30, 2017
…ad-hoc-page

Fix ad-hoc page css for new Patternfly version
(cherry picked from commit 99f6d78)
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit fa23ecd4139cb0254af2055dc06bfc5543881250
Author: Martin Hradil <himdel@seznam.cz>
Date:   Thu Mar 30 11:56:44 2017 +0000

    Merge pull request #826 from yaacov/fix-new-patternfly-regresions-in-ad-hoc-page
    
    Fix ad-hoc page css for new Patternfly version
    (cherry picked from commit 99f6d78bb9c1ec51f08c9277cc18d4395599cf77)

@simaishi
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants