Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow node reselect in trees where is no other way to get back #872

Merged
merged 5 commits into from Apr 3, 2017

Conversation

skateman
Copy link
Member

@skateman skateman commented Mar 31, 2017

Some views are displaying lists of elements that are not available on the left-side tree. If an element's summary screen is being displayed, there is nothing to select in the left-side tree, so it remains on the previously highlighted element, making it unclickable. This allows reselection in such cases, as it allows clicking on an already selected treenode.

https://bugzilla.redhat.com/show_bug.cgi?id=1438361

@miq-bot
Copy link
Member

miq-bot commented Mar 31, 2017

Checked commits skateman/manageiq-ui-classic@2e13235~...1d404e5 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
8 files checked, 0 offenses detected
Everything looks good. 🍪

@himdel himdel self-assigned this Apr 3, 2017
@himdel himdel added this to the Sprint 58 Ending Apr 10, 2017 milestone Apr 3, 2017
@himdel himdel merged commit e5dbbad into ManageIQ:master Apr 3, 2017
@skateman skateman deleted the allow-reselect branch April 3, 2017 11:25
simaishi pushed a commit that referenced this pull request Apr 3, 2017
Allow node reselect in trees where is no other way to get back
(cherry picked from commit e5dbbad)

https://bugzilla.redhat.com/show_bug.cgi?id=1438521
@simaishi
Copy link
Contributor

simaishi commented Apr 3, 2017

Fine backport details:

$ git log -1
commit a48acc58930046b2210e7732d5f0f26afa5d3dd6
Author: Martin Hradil <himdel@seznam.cz>
Date:   Mon Apr 3 11:22:58 2017 +0000

    Merge pull request #872 from skateman/allow-reselect
    
    Allow node reselect in trees where is no other way to get back
    (cherry picked from commit e5dbbad567695548815a0188244b1f60a52d65cd)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1438521

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants