Fix retirevms and vm_button_operations to account for it being called for objects other than VMOrTemplate #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label refactoring |
lgalis
changed the title
|
@miq-bot add_label bug |
lgalis
changed the title
lgalis
changed the title
lgalis
changed the title
|
Oh, I see, it's not just "vms" there are several types of entities handled by that code. @romanblanco , @PanSpagetka : need to me more careful with this. The comments as well as the variable names lie. You need to check buttons that lead to the particular place :-( |
| @@ -215,7 +215,8 @@ def ownership_update | |||
| # Retire 1 or more VMs | |||
There was a problem hiding this comment.
@lgalis, can you, please, remove the missleading comment and rename the variable vms to something that suggest that we deal here with different things?
lgalis
force-pushed
the
fix_find_checked_ids_with_rbac_for_retirement_call
branch
2 times, most recently
from
e3b7439
to
d724ecf
Compare
lgalis
changed the title
lgalis
force-pushed
the
fix_find_checked_ids_with_rbac_for_retirement_call
branch
from
d724ecf
to
f04da5e
Compare
lgalis
force-pushed
the
fix_find_checked_ids_with_rbac_for_retirement_call
branch
from
f04da5e
to
0ab8562
Compare
|
Checked commit lgalis@0ab8562 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
lgalis
changed the title
|
/cc @martinpovolny |
simaishi
pushed a commit
that referenced
this pull request
Apr 5, 2017
…r_retirement_call Fix retirevms and vm_button_operations to account for it being called for objects other than VMOrTemplate (cherry picked from commit 5523cfb) https://bugzilla.redhat.com/show_bug.cgi?id=1439295
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #852 changes, the retirement buttons do not work for services and orchestration stacks list selection.
https://bugzilla.redhat.com/show_bug.cgi?id=1438598
pivotal: https://www.pivotaltracker.com/story/show/140944305