Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop spinner on Container Image Condition screen #896

Merged
merged 1 commit into from Apr 4, 2017

Conversation

hayesr
Copy link
Contributor

@hayesr hayesr commented Apr 3, 2017

Stop spinner for ??? expression links

https://bugzilla.redhat.com/show_bug.cgi?id=1434896

Testing
This has ramifications for the advanced search under VMs, but that seems to suffer the same problem before this change.

Thanks, @h-kataria for the solution

@miq-bot
Copy link
Member

miq-bot commented Apr 3, 2017

Checked commit hayesr@1dbe4fe with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 🍪

@mzazrivec mzazrivec self-assigned this Apr 4, 2017
@mzazrivec mzazrivec added this to the Sprint 58 Ending Apr 10, 2017 milestone Apr 4, 2017
@mzazrivec mzazrivec merged commit f48a56c into ManageIQ:master Apr 4, 2017
simaishi pushed a commit that referenced this pull request Apr 4, 2017
Stop spinner on Container Image Condition screen
(cherry picked from commit f48a56c)
@simaishi
Copy link
Contributor

simaishi commented Apr 4, 2017

Fine backport details:

$ git log -1
commit 8a478b724d4a7edae5e8a0ee1b63685e88ddd31a
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Tue Apr 4 10:52:01 2017 +0200

    Merge pull request #896 from hayesr/fix_condition_infspin
    
    Stop spinner on Container Image Condition screen
    (cherry picked from commit f48a56c8868a4bfb3f703aca32fde3118c5c428e)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants