Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CopyCatalogForm test #9162

Merged
merged 1 commit into from Apr 26, 2024

Conversation

jeffibm
Copy link
Member

@jeffibm jeffibm commented Apr 19, 2024

yarn run jest -t 'Copy catalog form' --testPathPattern app/javascript/spec/copy-catalog-form/copy-catalog-form.spec.js

Before

console.error node_modules/react-dom/cjs/react-dom.development.js:88
    Warning: An update to TextField inside a test was not wrapped in act(...).
    
    When testing, code that causes React state updates should be wrapped into act(...):
    
    act(() => {
      /* fire events that update state */
    });
    /* assert on the output */
    
    This ensures that you're testing the behavior the user would see in the browser. Learn more at https://fb.me/react-wrap-tests-with-act
        in TextField (created by SingleField)
        in FormFieldHideWrapper (created by SingleField)
        in FormConditionWrapper (created by SingleField)
        in SingleField (created by FormRenderer)
        in form (created by Form)
        in Form (created by Form)
        in Form (created by FormTemplate)
        in FormTemplate (created by WrappedFormTemplate)
        in WrappedFormTemplate
        in Unknown (created by ReactFinalForm)
        in ReactFinalForm (created by FormRenderer)
        in FormRenderer (created by MiqFormRenderer)
        in MiqFormRenderer (created by Connect(MiqFormRenderer))
        in Connect(MiqFormRenderer) (created by CopyCatalogForm)
        in div (created by FlexGrid)
        in GridSettings (created by FlexGrid)
        in FlexGrid (created by Grid)
        in Grid (created by CopyCatalogForm)
        in CopyCatalogForm
        in Provider (created by WrapperComponent)
        in WrapperComponent

  console.error node_modules/react-dom/cjs/react-dom.development.js:88
    Warning: An update to FormSpy inside a test was not wrapped in act(...).
    
    When testing, code that causes React state updates should be wrapped into act(...):
    
    act(() => {
      /* fire events that update state */
    });
    /* assert on the output */
    
    This ensures that you're testing the behavior the user would see in the browser. Learn more at https://fb.me/react-wrap-tests-with-act
        in FormSpy (created by FormTemplate)
        in form (created by Form)
        in Form (created by Form)
        in Form (created by FormTemplate)
        in FormTemplate (created by WrappedFormTemplate)
        in WrappedFormTemplate
        in Unknown (created by ReactFinalForm)
        in ReactFinalForm (created by FormRenderer)
        in FormRenderer (created by MiqFormRenderer)
        in MiqFormRenderer (created by Connect(MiqFormRenderer))
        in Connect(MiqFormRenderer) (created by CopyCatalogForm)
        in div (created by FlexGrid)
        in GridSettings (created by FlexGrid)
        in FlexGrid (created by Grid)
        in Grid (created by CopyCatalogForm)
        in CopyCatalogForm
        in Provider (created by WrapperComponent)
        in WrapperComponent

  console.error node_modules/react-dom/cjs/react-dom.development.js:88
    Warning: An update to TextField inside a test was not wrapped in act(...).
    
    When testing, code that causes React state updates should be wrapped into act(...):
    
    act(() => {
      /* fire events that update state */
    });
    /* assert on the output */
    
    This ensures that you're testing the behavior the user would see in the browser. Learn more at https://fb.me/react-wrap-tests-with-act
        in TextField (created by SingleField)
        in FormFieldHideWrapper (created by SingleField)
        in FormConditionWrapper (created by SingleField)
        in SingleField (created by FormRenderer)
        in form (created by Form)
        in Form (created by Form)
        in Form (created by FormTemplate)
        in FormTemplate (created by WrappedFormTemplate)
        in WrappedFormTemplate
        in Unknown (created by ReactFinalForm)
        in ReactFinalForm (created by FormRenderer)
        in FormRenderer (created by MiqFormRenderer)
        in MiqFormRenderer (created by Connect(MiqFormRenderer))
        in Connect(MiqFormRenderer) (created by CopyCatalogForm)
        in div (created by FlexGrid)
        in GridSettings (created by FlexGrid)
        in FlexGrid (created by Grid)
        in Grid (created by CopyCatalogForm)
        in CopyCatalogForm
        in Provider (created by WrapperComponent)
        in WrapperComponent

  console.error node_modules/react-dom/cjs/react-dom.development.js:88
    Warning: An update to FormSpy inside a test was not wrapped in act(...).
    
    When testing, code that causes React state updates should be wrapped into act(...):
    
    act(() => {
      /* fire events that update state */
    });
    /* assert on the output */
    
    This ensures that you're testing the behavior the user would see in the browser. Learn more at https://fb.me/react-wrap-tests-with-act
        in FormSpy (created by FormTemplate)
        in form (created by Form)
        in Form (created by Form)
        in Form (created by FormTemplate)
        in FormTemplate (created by WrappedFormTemplate)
        in WrappedFormTemplate
        in Unknown (created by ReactFinalForm)
        in ReactFinalForm (created by FormRenderer)
        in FormRenderer (created by MiqFormRenderer)
        in MiqFormRenderer (created by Connect(MiqFormRenderer))
        in Connect(MiqFormRenderer) (created by CopyCatalogForm)
        in div (created by FlexGrid)
        in GridSettings (created by FlexGrid)
        in FlexGrid (created by Grid)
        in Grid (created by CopyCatalogForm)
        in CopyCatalogForm
        in Provider (created by WrapperComponent)
        in WrapperComponent

 PASS  app/javascript/spec/copy-catalog-form/copy-catalog-form.spec.js
  Copy catalog form
    ✓ should handle cancel (78ms)
    ✓ should handle submit (2021ms)

Test Suites: 1 passed, 1 total
Tests:       2 passed, 2 total
Snapshots:   0 total
Time:        5.81s

After

 PASS  app/javascript/spec/copy-catalog-form/copy-catalog-form.spec.js
  Copy catalog form
    ✓ should handle cancel (84ms)
    ✓ should handle submit (1027ms)

Test Suites: 1 passed, 1 total
Tests:       2 passed, 2 total
Snapshots:   0 total
Time:        5.249s

@jeffibm jeffibm added the test label Apr 19, 2024
@jeffibm jeffibm requested a review from a team as a code owner April 19, 2024 07:26
@miq-bot
Copy link
Member

miq-bot commented Apr 19, 2024

Checked commit jeffibm@bd9cfe6 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@jeffibm jeffibm mentioned this pull request Apr 19, 2024
35 tasks
@GilbertCherrie GilbertCherrie merged commit e880ea3 into ManageIQ:master Apr 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants