Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with timezones when adding new schedule #952

Merged
merged 1 commit into from Apr 7, 2017

Conversation

hayesr
Copy link
Contributor

@hayesr hayesr commented Apr 6, 2017

When adding a new automate task schedule the value for time zones are decoded, then if a time zone contains an ampersand (like Eastern (US & Canada) the value is split on the ampersand. This change leaves the time zone encoded when sent to the server.

https://bugzilla.redhat.com/show_bug.cgi?id=1435735

This bug also exists in Fine and Euwe

@miq-bot add_label bug, fine/yes, euwe/yes

/cc @h-kataria

@miq-bot
Copy link
Member

miq-bot commented Apr 6, 2017

Checked commit hayesr@519e6b0 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks good. 🍪

@mzazrivec mzazrivec self-assigned this Apr 7, 2017
@mzazrivec mzazrivec merged commit 5c71cd7 into ManageIQ:master Apr 7, 2017
simaishi pushed a commit that referenced this pull request Apr 7, 2017
Fix issue with timezones when adding new schedule
(cherry picked from commit 5c71cd7)

https://bugzilla.redhat.com/show_bug.cgi?id=1440318
@simaishi
Copy link
Contributor

simaishi commented Apr 7, 2017

Fine backport details:

$ git log -1
commit 86eda0530d6b9d554b8b38597ace626cda98caa8
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Fri Apr 7 11:44:16 2017 +0200

    Merge pull request #952 from hayesr/fix_schedule_tz
    
    Fix issue with timezones when adding new schedule
    (cherry picked from commit 5c71cd7cda8b3d1a06df0d54f7f32f478a18ea3a)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1440318

@simaishi
Copy link
Contributor

Euwe backport (to manageiq repo) details:

$ git log -1
commit 51ead743e28e70528fcbc74906383cd73fc93cb5
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Fri Apr 7 11:44:16 2017 +0200

    Merge pull request #952 from hayesr/fix_schedule_tz
    
    Fix issue with timezones when adding new schedule
    (cherry picked from commit 5c71cd7cda8b3d1a06df0d54f7f32f478a18ea3a)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1440401

@chessbyte chessbyte added this to the Sprint 58 Ending Apr 10, 2017 milestone Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants