Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Arbitration Profiles related toolbar buttons. #968

Merged

Conversation

h-kataria
Copy link
Contributor

@h-kataria h-kataria commented Apr 7, 2017

commit b65f1e8 added arbitration profiles related buttons and arbitration profiles toolbars back that were deleted in commit 862375b03a02b8f78be9577b1f11683ca169a284

https://bugzilla.redhat.com/show_bug.cgi?id=1440126

@dclarizio please review, these got added back in #173

commit b65f1e8 added arbitration profiles related buttons and arbitration profiles toolbars back that were deleted in commit 862375b03a02b8f78be9577b1f11683ca169a284

https://bugzilla.redhat.com/show_bug.cgi?id=1440126
@h-kataria h-kataria force-pushed the remove_arbitration_profile_add_button branch from 6ec49ec to 4c1fb8d Compare April 7, 2017 19:50
@miq-bot
Copy link
Member

miq-bot commented Apr 7, 2017

Checked commit h-kataria@4c1fb8d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 👍

@dclarizio dclarizio merged commit 540407e into ManageIQ:master Apr 7, 2017
@dclarizio dclarizio added this to the Sprint 58 Ending Apr 10, 2017 milestone Apr 7, 2017
simaishi pushed a commit that referenced this pull request Apr 7, 2017
…_button

Removed Arbitration Profiles related toolbar buttons.
(cherry picked from commit 540407e)

https://bugzilla.redhat.com/show_bug.cgi?id=1440322
@simaishi
Copy link
Contributor

simaishi commented Apr 7, 2017

Fine backport details:

$ git log -1
commit b905ebd55525fb08d2cc2652020ada8e0c0d5c9e
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Fri Apr 7 13:07:06 2017 -0700

    Merge pull request #968 from h-kataria/remove_arbitration_profile_add_button
    
    Removed Arbitration Profiles related toolbar buttons.
    (cherry picked from commit 540407e74e7e6d939a9d9742e8942ac198eee5fe)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1440322

@h-kataria h-kataria deleted the remove_arbitration_profile_add_button branch April 18, 2017 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants