Change typ to 'service' for Service/Requests page #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug |
mzazrivec
suggested changes
Apr 18, 2017
| when /ae/ then "AutomateRequest" | ||
| when /system/ then "MiqProvisionConfiguredSystemRequest" | ||
| when /host/ then "MiqHostProvisionRequest" | ||
| when /vm|service/ then "MiqProvisionRequest" |
There was a problem hiding this comment.
We should not be using regex here, just plain strings. This code needs to be working for exact
@layout values and we need to know what the actual matching values are for potential future
refactoring efforts.
There was a problem hiding this comment.
ok, sounds reasonable, going to revise them
jzigmund
force-pushed
the
bz1436316-remove_paging_from_requests
branch
from
82c7eec
to
34eda33
Compare
|
Checked commit jzigmund@34eda33 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
mzazrivec
approved these changes
Apr 19, 2017
simaishi
pushed a commit
that referenced
this pull request
Apr 19, 2017
…quests Change typ to 'service' for Service/Requests page (cherry picked from commit 5e0f438)
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Distinguish 'Services/Requests' action and don't display pagination for the Request lists
https://bugzilla.redhat.com/show_bug.cgi?id=1436316