-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sample skin + docs #235
Sample skin + docs #235
Conversation
@epwinchell if you ever have some extra time, maybe this sample skin deserves some love so that it actually looks good. But it is just a sample skin, so.. |
Checked commits https://github.com/himdel/manageiq-ui-self_service/compare/07808e3731d19543093f6f90e4f96b5b4ba16f28~...69a4d1c7f502e2491a3325730a3021fa66713385 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
The CC issues can't be fixed IMO... BTW @AllenBW should the scss linter check css files too? At least 2 of the errors don't even make sense for css.. |
@himdel I would say yessssssss we should be checking css files ALL TEH FILES seriously though, if these things cant be changed, welp tough luck codeclimate we're not changing them! <3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤘 ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please address the code climate issues?
@chriskacerguis Nope, sorry, I cannot :). Not without breaking it.. |
@himdel not arguing, but for the sake of completeness could you maybe shed some light on to why you feel that way? |
Yup, already on it.. :)
Not without breaking everybody's skin.. - it's overriding styling for this class (actaully, we're using BEM AFAIK so .. different convention even - will investigate)
Not in CSS
Not in CSS.
Well, yes, it's an override. |
Thanks @himdel makes sense to me! |
Merging due to @himdel code additions being "valid". |
This adds a
skin-sample
folder, containing a simple sample skin, and a README describing how the skinning works, where to look, and what to override.If everybody agrees with the wording of the README, I'll do a similar PR with just the readme to ManageIQ/guides so that it's part of the devel docs as well.
Applying the skin:
skin-sample/link.sh
(optionally with the path to the ssui folder)Unapplying:
skin-sample/unlink.sh
(orrm client/skin
)Closes #115