Skip to content

Commit

Permalink
Merge pull request #1699 from himdel/fix-mks
Browse files Browse the repository at this point in the history 
WebMKS: fix mix of common js and import/export
  • Loading branch information
@h-kataria
h-kataria committed Mar 2, 2021
2 parents 8fbe42a + 0b255a8 commit 2b6d4a8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion client/console/common.js
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import languageFile from '../gettext/json/manageiq-ui-service.json'

module.exports = () => {
export default function() {
const urlParams = new URLSearchParams(window.location.search)

const params = ['path', 'is_vcloud', 'vmx', 'lang'].reduce((map, obj) => {
Expand Down
2 changes: 1 addition & 1 deletion client/console/webmks.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ require('jquery-ui-bundle')
require('es6-shim')
require('patternfly/dist/css/patternfly.css')
require('patternfly/dist/css/patternfly-additions.css')
let initRemoteConsole = require('./common')
let initRemoteConsole = require('./common').default;

/* global WMKS */

Expand Down

7 comments on commit 2b6d4a8

@vitorlube
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do apply this fix to my lasker-1? Im using the appliance for vmware.

@chessbyte
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vitorlube try a recent Lasker build (one that happened after the backport of this fix to the lasker branch) from https://releases.manageiq.org/index.html

@vitorlube
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chessbyte thanks i will try right now, but i wonder if there is a way of updating mine without having to install another appliance.

@chessbyte
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fryguy @bdunne if there is a way, they would know

@bdunne
Copy link
Member

@bdunne bdunne commented on 2b6d4a8 Dec 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dnf update once there's a new lasker build

@vitorlube
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok guys, i did the download of the last lasker-1 (from yesterday) i started from scratch with the ova.

image

and also copy the sdk from vmware (to use webmks) using this guide:
https://www.manageiq.org/docs/reference/latest/managing_infrastructure_and_inventory/index.html#configuring-webmks-support-in-manageiq

I also added the vcenter certificate to the appliance.
But unfortunally i still cant see the button to change web console (like bellow in hammer) to webmks and when i click the console it kept only "connecting":

image

Is there something im doing wrong?

@miq-bot
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit has been mentioned on ManageIQ Forum. There might be relevant details there:

https://talk.manageiq.org/t/webmks-lasker-1/5536/9

Please sign in to comment.