Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create RBAC roles / features #1054

Closed
1 of 29 tasks
chriskacerguis opened this issue Oct 3, 2017 · 17 comments
Closed
1 of 29 tasks

Create RBAC roles / features #1054

chriskacerguis opened this issue Oct 3, 2017 · 17 comments
Assignees

Comments

@chriskacerguis
Copy link
Contributor

chriskacerguis commented Oct 3, 2017

Per @Loicavenel comment here we need to add RBAC to the following:

Core

  • Application Launcher
  • Switch Language

Dashboard

  • Monthly charge view

My Services

  • View / Show
  • Start
  • Stop
  • Suspend
  • Set Retirement Date
  • Edit
  • Remove
  • Set Ownership

VM Resource

  • View Details
  • View Snapshots
  • Create Snapshot
  • Delete Snapshot
  • Open Remote Console
  • Open Web Console
  • Retire
  • Start
  • Stop

My Orders

  • View / Show
  • Duplicate
  • Modify
  • Remove

Service Catalog

  • View / Show
  • Add to Shopping Cart

Shopping Cart

  • View / Show
  • Clear
  • Order
@Loicavenel
Copy link

Just few points:
Core Can be renamed Top Menu or something else, I did not have better idea
This is missing the new stuff we are adding in 4.6..
We have to review VM resources here, it may be Resources with Sub Item like VM, Generic Object, Playbook etc... And for VM we can be granular on what we show: part of the dashboard for example

@AllenBW
Copy link
Member

AllenBW commented Oct 3, 2017

I wanta chime in here, been said before, will be said again, we should not add these roles to product_features.yml in manageiq until they are mapped to a behavior in the SUI, it would be dreadfully cruel and confusing to show users something that does nothing.

I propose twin prs, one in the sui that takes advantage of the feature, and another in manageiq that adds the feature. Never one without the other 😆

@chriskacerguis
Copy link
Contributor Author

@AllenBW totally agree.

@Loicavenel
Copy link

@AllenBW @chriskacerguis my goal was not asking to implement role but to make sure we have a clear list.. And yes, we should implement it feature after feature. I hope we can have it in Errata.

@chriskacerguis
Copy link
Contributor Author

@Loicavenel understood.

@chalettu
Copy link
Contributor

@miq-bot add_label wip

@miq-bot miq-bot changed the title Create RBAC roles / features [WIP] Create RBAC roles / features Oct 11, 2017
@miq-bot miq-bot added the wip label Oct 11, 2017
@Loicavenel
Copy link

@chalettu we need to organise it better and follow what was done already exist to don't confuse Customers

Self Service
Core
Application Launcher
Switch Language
Dashboard
Monthly charge view
My Services
View
Show
Operate
Start
Stop
Suspend
Edit Tags
Set Retirement Date
Retire Service
Modify
Edit
Remove
Set OwnerShip
VM Resources
View
Details
Snapshot
Operate
Create Snapshots
Delete All Snapshots
Open Remote Console
Open Web Console
Edit Tag
Retire
Stop
Start
My Orders
View
Show
Operate
Duplicate
Modify
Remove
Service Catalog
View
Show
Operate
Add to Shopping Cart
Shopping Cart
View
Show
Operate
Clear
Order

@AllenBW
Copy link
Member

AllenBW commented Oct 11, 2017

@Loicavenel wanta confirm, use of Self Service should be Service? (first item in your list)

@AllenBW
Copy link
Member

AllenBW commented Oct 11, 2017

Also Think we should rename Delete All Snapshots to Delete Snapshots, deleting all or a single one can both be wrapped up in that permission...

Ok quick question... we have Remove For Orders, Services but Delete for Snapshots and Clear for the shopping cart... Thoughts on clearing up the wording inconsistencies around deleting things from places?

@Loicavenel
Copy link

Guys, sorry for the formatting here.. I thought Github will keep it..
All in the doc here. https://docs.google.com/document/d/10p69nnTT7dG0hnCBCJkcapjlxVd08J0A2QRX054B_08/edit

@chalettu
Copy link
Contributor

@Loicavenel , can you post the finalized structure of permissions you would like to appear in the Classic UI?

@Loicavenel
Copy link

@chalettu It is in the Doc, I not sure or to post it in Github.. in which format

@chalettu
Copy link
Contributor

rbac1

rbac_2

rbac_3

Here is the structure I have implemented. I had to split it into 3 images so I could expand the structure

@AllenBW
Copy link
Member

AllenBW commented Oct 11, 2017

(Replying to @Loicavenel's comments in the google doc) Indeed, the ui says, Delete All Snapshots, maybe this indicative of a broader need to audit and standardize functional wordings across the SUI, thoughts @chriskacerguis @Loicavenel @chalettu @serenamarie125 ?

So just as people shouldn't be confused mapping product features to ui buttons, consistency across naming of product features should be in place as well, just because the thesaurus contains countless alternatives for the word 'delete' does not mean we should be experimenting with how many we can employ

@chalettu
Copy link
Contributor

@miq-bot remove_label wip

@miq-bot miq-bot changed the title [WIP] Create RBAC roles / features Create RBAC roles / features Oct 16, 2017
@miq-bot miq-bot removed the wip label Oct 16, 2017
@chriskacerguis
Copy link
Contributor Author

merged.

@chriskacerguis
Copy link
Contributor Author

#1090

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants