Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to hide toasts based on RBAC #1053

Merged
merged 1 commit into from Oct 3, 2017
Merged

Added ability to hide toasts based on RBAC #1053

merged 1 commit into from Oct 3, 2017

Conversation

chalettu
Copy link
Contributor

@chalettu chalettu commented Oct 3, 2017

@miq-bot add_label enhancement
@miq-bot add_label fine/no

@chalettu
Copy link
Contributor Author

chalettu commented Oct 3, 2017

@chalettu chalettu changed the title [Finishes #1052] Added ability to hide toasts based on role Added ability to hide toasts based on role Oct 3, 2017
@chalettu chalettu changed the title Added ability to hide toasts based on role Added ability to hide toasts based on RBAC Oct 3, 2017
@miq-bot
Copy link
Member

miq-bot commented Oct 3, 2017

Checked commit https://github.com/chalettu/manageiq-ui-service/commit/12b4ccf5ac709df28b5efde94cb8dd598065b238 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@chalettu
Copy link
Contributor Author

chalettu commented Oct 3, 2017

This PR is dependent on ManageIQ/manageiq#16107 getting merged

@chriskacerguis chriskacerguis self-assigned this Oct 3, 2017
@chriskacerguis chriskacerguis added this to the Sprint 71 Ending Oct 16, 2017 milestone Oct 3, 2017
@Loicavenel
Copy link

@chalettu @chriskacerguis are we using the Role section we are implementing?

@chalettu
Copy link
Contributor Author

chalettu commented Oct 3, 2017

illustration

@Loicavenel , this is where in Classic UI you would go to enable/disable notifications

@Loicavenel
Copy link

Ok, we are good. thx

@chalettu
Copy link
Contributor Author

chalettu commented Oct 3, 2017

@Loicavenel , FYI. All the PR's for allowing SUI to define its own Product features like above illustration were all merged as of yesterday. Now we can build on that functionality for any features you want to enable to be disabled granularly. Note: I just put in a PR for the notification permission this morning so that particular permission isn't merged yet but should be soon.

Copy link
Member

@AllenBW AllenBW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M <3 🙇‍♀️

@Loicavenel
Copy link

@chalettu can you share the structure or we have only Notification and App Launcher for now?

@chriskacerguis chriskacerguis merged commit 9f0b625 into ManageIQ:master Oct 3, 2017
@chalettu
Copy link
Contributor Author

chalettu commented Oct 3, 2017

@Loicavenel , the structure pictured above is all we have defined to date. We wanted to start incrementally. Now that we have the plumbing in place, I think you and @chriskacerguis can sit down and decide on a master list we would like to add.

@AllenBW
Copy link
Member

AllenBW commented Oct 3, 2017

Probably should start by remapping all rbac that relied on existing product features... one of the many applicable places

@Loicavenel
Copy link

@chalettu I did provide a doc about a proposed structure.. https://drive.google.com/open?id=10p69nnTT7dG0hnCBCJkcapjlxVd08J0A2QRX054B_08

@chriskacerguis
Copy link
Contributor

@Loicavenel could we put that tree in this ticket?

@Loicavenel
Copy link

Sure. then people can review it.

@chriskacerguis chriskacerguis mentioned this pull request Oct 3, 2017
29 tasks
@chalettu chalettu deleted the notifications-visibility branch January 10, 2018 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants